187178550 v3 DI Delete Improvements

tealefristoe commented 1 month ago

PT Story: https://www.pivotaltracker.com/story/show/187178550

This PR makes several improvements related to deleting items.

Deleting items now broadcasts a notification like it does in v2. The lack of notifications was causing a bug in the Collaborative plugin.
- In order to include the deleted cases in the notification, a new volatile property has been added, DataSet.itemIdChildCaseMap. This links each item to the child case that contains it, and is computed in validateCases.
It's now possible to batch items in a delete item API request. This is much more efficient than sending a separate API request for each item to be deleted. An API request that deletes multiple items looks like this:
```
{
"action": "delete",
"resource": "dataContext[Mammals].item",
"values": [
{ "id": 1 },
{ "id": 2 },
...
]
}
```
The delete case(s) option is now disabled in the case menu (comes up when you click on the index cell) when the plugin prevents the case from being edited. Now this menu item is consistent with the delete all/selected/unselected cases menu items in the trash menu, and protects other users' data in shared tables.
- I also disabled the insert case(s) options here at the request of Dan.

cypress[bot] commented 1 month ago

Test summary

204 • 0 • 29 • 0 • 1

Run details


Project	codap-v3
Status	Passed
Commit	564c4ec3e5
Started	Aug 14, 2024 3:36 AM
Ended	Aug 14, 2024 3:44 AM
Duration	08:13 💡
OS	Linux Ubuntu -
Browser	Chrome 127

View run in Cypress Cloud ➡️

Flakiness

	cypress/e2e/toolbar.spec.ts		1
1	codap toolbar > will open a slider

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (81c2675) to head (b88ca25). Report is 4 commits behind head on main.

Files	Patch %	Lines
v3/src/components/case-table/index-menu-list.tsx	85.71%	1 Missing :warning:
v3/src/models/data/data-set-undo.ts	83.33%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1397 +/- ## ========================================== - Coverage 85.95% 85.94% -0.02% ========================================== Files 533 533 Lines 25988 26038 +50 Branches 7083 7106 +23 ========================================== + Hits 22339 22378 +39 + Misses 3494 3381 -113 - Partials 155 279 +124 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.55% <65.62%> (-0.11%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.93% <80.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

concord-consortium / codap