Closed bfinzer closed 3 weeks ago
Attention: Patch coverage is 43.16310%
with 345 lines
in your changes missing coverage. Please review.
Project coverage is 71.47%. Comparing base (
7372552
) to head (07e811e
). Report is 1 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (7372552) and HEAD (07e811e). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (7372552) | HEAD (07e811e) | |------|------|------| |jest|1|0|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 50fdc6d2f6 |
Started | Aug 16, 2024 7:25 PM |
Ended | Aug 16, 2024 7:33 PM |
Duration | 08:25 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 127 ![]() |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
The other thing I forgot to mention in my review, is that we're going to want some tests. If we don't want to hold up this PR, then we should plan to come back to them. There are a number of utility functions that should be straightforward to test with jest tests and then we should have a cypress test that brings up a date axis.
@bfinzer I see that there's a failing jest test which should be addressed before merging as well.
[#181971361] Feature: Date attributes can be plotted on a date-time axis
This is a "first pass" implementation of a date-time axis. Missing features and bugs should be logged in separate PT stories unless they break non-date-time axes or otherwise disrupt normal V3 behavior.
AbstractNumericAxisModel
with descendantNumericAxisModel
AbstractNumericAxisModel
setupAxes
isAbstractNumeric
isAbstractNumericAxisModel
and use it, where appropriate, in place ofisNumericAxisModel