chore: fix cypress TypeScript types

kswenson commented 4 weeks ago

Since v3 development began, the TypeScript configuration for our cypress tests has been mis-configured, resulting in a blizzard of red squiggles (compile errors) in every cypress test file. I (finally) reached the point of being sufficiently annoyed by this to do something about it. Running the TypeScript compiler on the cypress sources before this PR resulted in 1,917 errors. This PR reduces that number to zero by:

Making cypress types available by adding "types": ["cypress"] to the cypress/tsconfig.json file.
Adding a build:cypress command to package.json which "compiles" (i.e. type-checks) the cypress source files.
Adding build:cypress to the set of tasks triggered by npm run build.
- This means that errors in the cypress test files will cause the build to fail.
Adding ambient type declarations for our cypress extensions, e.g. the commands defined in commands.ts.
Fixing the remaining blizzard of type errors from untyped function arguments and local variables, etc.
Reducing the wait in the dragAttributeToTarget command from 2500 to 1000.
Fixing a type error in axis-spec.ts that resulted in code for checking axis ticks not running.
Eliminating dozens of waits from the axis-spec.ts test.
Fixing a smattering of other small issues that I encountered along the way.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.95%. Comparing base (81c2675) to head (9c5b293).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1401 +/- ## ======================================== Coverage 85.95% 85.95% ======================================== Files 533 533 Lines 25988 25988 Branches 7083 7083 ======================================== Hits 22339 22339 + Misses 3494 3371 -123 - Partials 155 278 +123 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1401/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.64% <ø> (-0.01%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1401/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.80% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 4 weeks ago

Test summary

204 • 0 • 29 • 0 • 1

Run details


Project	codap-v3
Status	Passed
Commit	10b52eeac6
Started	Aug 13, 2024 11:39 PM
Ended	Aug 13, 2024 11:47 PM
Duration	08:34 💡
OS	Linux Ubuntu -
Browser	Multiple

View run in Cypress Cloud ➡️

Flakiness

	cypress/e2e/toolbar.spec.ts		1
1	codap toolbar > will open a map

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

concord-consortium / codap