codecov[bot]
commented
4 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.97%. Comparing base (
564c4ec) to head (1662eef). Report is 3 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1402 +/- ## ======================================== Coverage 85.97% 85.97% ======================================== Files 533 533 Lines 26038 26038 Branches 7048 6656 -392 ======================================== Hits 22386 22386 - Misses 3374 3497 +123 + Partials 278 155 -123 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1402/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.59% <ø> (+<0.01%)` | :arrow_up: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1402/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.93% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cypress[bot]
Recently, @nstclair-cc encountered an issue whereby
lint:buildfailed with a module resolution error but all other commands (lint,build:webpack,test) succeeded. Seemed likely to be a caching issue butclean:cachedidn't fix it. 🤔 Only later did I realize that the lint caches aren't cleared byclean:cachebecause they aren't stored in thenode_modules/.cachefolder with the other caches (e.g. webpack's). This PR fixes that so that the lint caches are innode_modules/.cachealong with our other development-related caches, which means that theclean:cachecommand clears the lint caches as well.Note that I've removed the old files from the
.gitignorefile, so that developers with existing repositories may encounter unversioned files named.eslintcacheand.eslintcache.buildin their workspace. These files can safely be deleted.