concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

188104017 v3 Input Row Tab #1403

Closed tealefristoe closed 3 weeks ago

tealefristoe commented 4 weeks ago

PT Story: https://www.pivotaltracker.com/story/show/188104017

In a shared table, pressing the tab key in the input row would result in two cases being added to the table. This didn't happen in normal tables. This PR fixes that issue by removing onBlur handlers from CellTextEditor and ColorCellTextEditor, which seem to be unnecessary.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.80%. Comparing base (78bafaa) to head (8f90c4e). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1403 +/- ## ========================================== - Coverage 85.91% 85.80% -0.12% ========================================== Files 533 533 Lines 26066 26061 -5 Branches 7063 7111 +48 ========================================== - Hits 22395 22361 -34 - Misses 3393 3545 +152 + Partials 278 155 -123 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1403/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.39% <ø> (-0.15%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1403/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.86% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 4 weeks ago



Test summary

204 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit e52669a62b
Started Aug 15, 2024 1:16 PM
Ended Aug 15, 2024 1:24 PM
Duration 08:29 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud