concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

fix: flaky tool shelf cypress test #1404

Closed kswenson closed 3 weeks ago

kswenson commented 4 weeks ago

I was able to reproduce the failures pretty reliably running locally on my machine without this fix and haven't been able to reproduce them with it.

cypress[bot] commented 4 weeks ago



Test summary

204 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 30bc16d306
Started Aug 15, 2024 12:19 AM
Ended Aug 15, 2024 12:27 AM
Duration 08:23 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.39%. Comparing base (78bafaa) to head (b11c9b0). Report is 2 commits behind head on main.

:exclamation: There is a different number of reports uploaded between BASE (78bafaa) and HEAD (b11c9b0). Click for more details.

HEAD has 6 uploads less than BASE | Flag | BASE (78bafaa) | HEAD (b11c9b0) | |------|------|------| |jest|2|0| |cypress|9|5|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1404 +/- ## =========================================== - Coverage 85.91% 72.39% -13.52% =========================================== Files 533 527 -6 Lines 26066 22731 -3335 Branches 7063 6391 -672 =========================================== - Hits 22395 16457 -5938 - Misses 3393 6089 +2696 + Partials 278 185 -93 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1404/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1404/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.39% <ø> (-0.15%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1404/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nstclair-cc commented 3 weeks ago

Looks good to me! 👍🏼 I left a comment about using {force: true} with Cypress clicks, which I believe John and I discussed recently. I'll dig into my notes to refresh my memory and will chat with John about it. The "will open a webpage" test failed locally the first time I ran it, but it passed when I reran it, so I think it's fine for now. I'll keep an eye on the spec going forward.