Closed bfinzer closed 3 weeks ago
Attention: Patch coverage is 74.07407%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 85.91%. Comparing base (
78bafaa
) to head (b6f041c
). Report is 12 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
v3/src/components/graph/components/graph.tsx | 74.07% | 7 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Project | codap-v3 |
Status | Passed |
Commit | 2253ad3381 |
Started | Aug 15, 2024 5:20 PM |
Ended | Aug 15, 2024 5:28 PM |
Duration | 08:30 💡 |
OS | Linux Ubuntu - |
Browser | Chrome 127 ![]() |
![]() |
cypress/e2e/text.spec.ts ![]() |
1 ![]() |
|
---|---|---|---|
1 | Text tile > updates text title with undo/redo |
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud
[#187798725] Bug fix: Graph turns into scatterplot when creating new collections in Mammals dataset
This fixes the graph bugs related to move an attribute within a dataset. But a bug occurs when the attribute is moved to a parent collection and then the user presses Undo. See #188117637.
attribute.completeSnapshot
fromattribute-menu-list.ts handleClick
so that MST won't complain.RemoveAttributeAction
indata-set-actions
removed because no longer called.onAnyAction
inhandleDeleteAttribute
to an mstReaction in what is nowhandleAttributeCollectionMapChange
. This detects both deletion and moving of attributes to different collections.