codecov[bot]
commented
3 weeks ago Codecov Report
Attention: Patch coverage is 74.07407% with 7 lines in your changes missing coverage. Please review.
Project coverage is 85.91%. Comparing base (
78bafaa) to head (b6f041c). Report is 12 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| v3/src/components/graph/components/graph.tsx | 74.07% | 7 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1405 +/- ## ========================================== - Coverage 85.91% 85.91% -0.01% ========================================== Files 533 533 Lines 26066 26079 +13 Branches 7063 7115 +52 ========================================== + Hits 22395 22405 +10 - Misses 3393 3519 +126 + Partials 278 155 -123 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1405/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1405/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.53% <76.00%> (-0.01%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1405/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.82% <3.70%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cypress[bot]
[#187798725] Bug fix: Graph turns into scatterplot when creating new collections in Mammals dataset
This fixes the graph bugs related to move an attribute within a dataset. But a bug occurs when the attribute is moved to a parent collection and then the user presses Undo. See #188117637.
attribute.completeSnapshotfromattribute-menu-list.ts handleClickso that MST won't complain.RemoveAttributeActionindata-set-actionsremoved because no longer called.onAnyActioninhandleDeleteAttributeto an mstReaction in what is nowhandleAttributeCollectionMapChange. This detects both deletion and moving of attributes to different collections.