search

concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

188104291 v3 DI Return Table to Normal after Sharing #1406

Closed tealefristoe closed 3 weeks ago

tealefristoe commented 3 weeks ago

PT Story: https://www.pivotaltracker.com/story/show/188104291

Previously, a shared table was not disconnecting from its managing controller after sharing stopped. This PR fixes that bug.

cypress[bot] commented 3 weeks ago


Test summary

204 • 0 • 29 • 0 • Flakiness 0

Run details
Project codap-v3
Status Passed
Commit f0767c4ca7
Started Aug 15, 2024 2:51 PM
Ended Aug 15, 2024 2:59 PM
Duration 08:20 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.80%. Comparing base (78bafaa) to head (bbd15d8). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1406 +/- ## ========================================== - Coverage 85.91% 85.80% -0.12% ========================================== Files 533 533 Lines 26066 26066 Branches 7063 6667 -396 ========================================== - Hits 22395 22366 -29 - Misses 3393 3545 +152 + Partials 278 155 -123 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1406/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.40% <25.00%> (-0.14%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1406/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.85% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.