search

concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

182089941 add log strings maps #1407

Closed eireland closed 2 weeks ago

eireland commented 3 weeks ago

Add logging to map actions:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 65.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 84.93%. Comparing base (b6f041c) to head (bfcd6bf). Report is 54 commits behind head on main.

Files Patch % Lines
.../src/components/map/components/map-grid-slider.tsx 25.00% 6 Missing :warning:
...nents/map/components/map-marquee-select-button.tsx 16.66% 5 Missing :warning:
v3/src/components/map/models/leaflet-map-state.ts 81.81% 2 Missing :warning:
v3/src/components/map/components/codap-map.tsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1407 +/- ## ========================================== - Coverage 85.91% 84.93% -0.98% ========================================== Files 533 540 +7 Lines 26079 26861 +782 Branches 7115 7283 +168 ========================================== + Hits 22405 22814 +409 - Misses 3519 3742 +223 - Partials 155 305 +150 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1407/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1407/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `71.32% <53.57%> (-1.22%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1407/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.31% <37.50%> (-0.51%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 3 weeks ago

codap-v3    Run #4086

Run Properties:  status check passed Passed #4086  •  git commit 41dcfa864f: 182089941 add log strings maps (#1407)
Project codap-v3
Branch Review main
Run status status check passed Passed #4086
Run duration 08m 16s
Commit git commit 41dcfa864f: 182089941 add log strings maps (#1407)
Committer Evangeline Ireland
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 29
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 206
View all changes introduced in this branch ↗︎