codecov[bot]
commented
3 weeks ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.92%. Comparing base (
b6f041c) to head (fb93ec0). Report is 15 commits behind head on main.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #1409 +/- ## ========================================== + Coverage 85.91% 85.92% +0.01% ========================================== Files 533 533 Lines 26079 26104 +25 Branches 7115 6684 -431 ========================================== + Hits 22405 22430 +25 Misses 3519 3519 Partials 155 155 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1409/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1409/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.49% <100.00%> (-0.05%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1409/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.87% <42.85%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cypress[bot]
bacalj
PT Story: https://www.pivotaltracker.com/story/show/188125035
There was confusion between items and cases in the
selectCasesNotification, which was resulting in notifications with almost all undefined values being included. This PR fixes the issue by finding the actual cases selected/deselected, rather than the items. Unfortunately, this is O(items * collections), rather than O(items) as before.