concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

feat: Update plugins menu configuration #1410

Closed kswenson closed 3 weeks ago

kswenson commented 3 weeks ago

[PT-188117294] [PT-188124952] [PT-188015800]

For instance, morePlugins=https://codap-resources.s3.amazonaws.com/plugins/published-plugins.json will load a redundant set of plugin items into the plugins menu.

Note that we also remove a cy.intercept() that was added to handle failures to fetch the remote plugin configuration as well as a bunch of cy.log()s around the setup of each test that were added specifically to debug these failure to fetch errors.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.80%. Comparing base (7372552) to head (9cf2044). Report is 1 commits behind head on main.

Files Patch % Lines
v3/src/components/tool-shelf/plugins-button.tsx 86.66% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1410 +/- ## ========================================== - Coverage 85.89% 85.80% -0.09% ========================================== Files 533 533 Lines 26094 26104 +10 Branches 6684 7135 +451 ========================================== - Hits 22413 22399 -14 + Misses 3526 3423 -103 - Partials 155 282 +127 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1410/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `72.33% <82.14%> (-0.11%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.86% <82.85%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 3 weeks ago



Test summary

204 0 29 0Flakiness 1


Run details

Project codap-v3
Status Passed
Commit 25de329963
Started Aug 19, 2024 5:11 PM
Ended Aug 19, 2024 5:19 PM
Duration 08:17 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


Flakiness

cypress/e2e/text.spec.ts Flakiness
1 Text tile > updates text title with undo/redo

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud