concord-consortium / codap

CODAP (Common Online Data Analysis Platform)
MIT License
94 stars 38 forks source link

Scatterplot grid lines with date axis #1411

Closed bfinzer closed 3 weeks ago

bfinzer commented 3 weeks ago

[#188109499] Bug fix: Date axis grid lines missing for scatterplot

cypress[bot] commented 3 weeks ago



Test summary

204 0 29 0Flakiness 0


Run details

Project codap-v3
Status Passed
Commit 773ec24ef1
Started Aug 21, 2024 12:02 AM
Ended Aug 21, 2024 12:10 AM
Duration 08:35 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 8.75000% with 73 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (b6f041c) to head (c34e7c9). Report is 30 commits behind head on main.

Files Patch % Lines
.../components/axis/helper-models/date-axis-helper.ts 8.86% 72 Missing :warning:
v3/src/components/axis/hooks/use-sub-axis.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1411 +/- ## ========================================== - Coverage 85.91% 84.74% -1.17% ========================================== Files 533 539 +6 Lines 26079 26643 +564 Branches 7115 7267 +152 ========================================== + Hits 22405 22578 +173 - Misses 3519 3759 +240 - Partials 155 306 +151 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1411/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `71.37% <1.31%> (-1.17%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1411/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.23% <8.75%> (-0.59%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.