fix: date arithmetic; inequality comparisons involving dates, numbers, and strings

kswenson commented 4 weeks ago

[PT-188136564] Formula today() should not be affected by time zone [PT-188102629] Formula today()+24*3600 yields a number, not a date [PT-188136819] Relational operators support strings, dates [PT-188136625] Dates without hours/minutes should not display hours/minutes by default [PT-188104615] Support less-restrictive date validation

Addition/subtraction involving dates return Date objects rather than date-formatted strings.
Adding two Date objects or subtracting a Date object from a number return errors.
Implement custom relative comparison operators (<, <=, >, >=) that support Date objects (compared numerically), auto-converts strings to numbers where possible, and supports comparing strings otherwise.
When serializing ISO strings, subtract local time zone offset and then add it back when deserializing so that, for instance, midnight local time is serialized as midnight UTC and then deserialized back to local time.
Allows out-of-range values when constructing dates, following JavaScript Date object semantics and existing v2 behavior.

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.96%. Comparing base (b6f041c) to head (ea31f36). Report is 28 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1413 +/- ## ========================================== - Coverage 85.91% 84.96% -0.95% ========================================== Files 533 540 +7 Lines 26079 26697 +618 Branches 7115 6827 -288 ========================================== + Hits 22405 22683 +278 - Misses 3519 3859 +340 Partials 155 155 ``` | [Flag](https://app.codecov.io/gh/concord-consortium/codap/pull/1413/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | Coverage Δ | | |---|---|---| | [cypress](https://app.codecov.io/gh/concord-consortium/codap/pull/1413/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `71.42% <40.00%> (-1.12%)` | :arrow_down: | | [jest](https://app.codecov.io/gh/concord-consortium/codap/pull/1413/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium) | `53.36% <93.44%> (-0.46%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=concord-consortium#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cypress[bot] commented 4 weeks ago

Test summary

204 • 0 • 29 • 0 • 2

Run details


Project	codap-v3
Status	Passed
Commit	088aa8f00e
Started	Aug 20, 2024 5:43 PM
Ended	Aug 20, 2024 5:51 PM
Duration	08:35 💡
OS	Linux Ubuntu -
Browser	Multiple

View run in Cypress Cloud ➡️

Flakiness

	table.spec.ts	1
1	case table ui > case table header attribute menu > edits, re-randomizes, and deletes formulas
	text.spec.ts	1
1	Text tile > updates text title with undo/redo

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

concord-consortium / codap