ddamelin
commented
9 years ago The initial work looks good. In the future it would be better to name the branch something related to the work or interactive name. I'm a bit confused by the "merge pull request" commits. On your own repo you can merge branches without having to issue pull requests. To keep your branch up to date you can sync the master branch with our upstream master, then rebase your branch with your master.
For now I have some other requests for changes on this interactive, so you can keep working in this branch, and resubmit the pull request to get the new features in.
Other changes would be:
- Move the set of controls on the right more to the left.
- Move the KE shading control up next to the slow motion control.
- Extend the slider so it is longer.
- Make it so that there are finer steps for the slider to give more precise velocity values.
- Change the bond strength of the Oxygen and Nitrogen molecules. They are currently incorrect. Hydrogen is OK, but the values used for oxygen and nitrogen need to be changed. Oxygen should have strength 936 and nitrogen 1779.
- Then adjust the range of the slider so that the lowest value is a velocity somewhat below what is needed to break hydrogen, and the max value is somewhat above what is needed to break nitrogen.
Rishi. Thanks for doing this. I'm on vacation this week, but I will try to check in on this soon, and likely ask for a new change on another interactive.