concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

Dissociation energy version 2 #26

Closed bhavna19nagpal closed 9 years ago

bhavna19nagpal commented 9 years ago

The newer version has 1) KE on by default in the beginning 2) Bonded atoms in the beginning 3) dissociation-slider getting disabled on play.

ddamelin commented 9 years ago

This was a good start. I would recommend two changes.

If you do future additional work it would be helpful to make a branch in your fork that is somewhat descriptive of the work contained in the pull request. Typically, when working on interactives some branch name related to that interactive. For now you can make these changes in this branch and update the pull request.

rklancer commented 9 years ago

"The Effect of Temperature", please.

With regards, your friendly local grammar cop

ddamelin commented 9 years ago

Thank you!

rklancer commented 9 years ago

You're welcome! Just saw "the affect of temperature" in my inbox and thought, "hmm." Although the warmer temperatures lately have had the effect of positively affecting my overall affect, so maybe there's something to the former title :)