search

concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

dissociation-energy version 2 #32

Closed bhavna19nagpal closed 9 years ago

bhavna19nagpal commented 9 years ago

Sir, The setBondBnergy call has been corrected in the onLoad section. After my last comment, I tried making changes and wasn't able to rebase, so I tried it again and made a new pull request. Also, I will keep in mind if my code is running locally , before submitting

Thank you.

ddamelin commented 9 years ago

Hi Bahvna,

There are still issues here. The conventions for indenting code were not followed, and the value you chose for the bond energy doesn't allow for the bonds to break even at the highest temperatures. We have similar work in another branch which has been waiting in another pull request. Thank you for attempting to work on this, but I'm going to pull the work from the other branch and close this pull request.

-Dan