concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

Maintenance: use Yarn, update s3_website, .travis.yml, Dockerfile #62

Closed pjanik closed 7 years ago

pjanik commented 7 years ago

It's related to this PR: https://github.com/concord-consortium/lab/pull/120 I've started it, as I've had some issues with NPM recently (not for the first time). Also, I remember people complaining about Lab / lab-interactive-site build process and setup, and I guess that it can be related to NPM sometimes. Yarn makes dependency resolving deterministic. I've made Yarn dependency optional (in Makefile), so authors and developers don't have to switch immediately.

Also, I've updated s3_webiste gem (I had to do it in Lab to support latest Node, so I did it here too). Dockefile is updated to use Yarn and newer Node (that's why I've switched Ubuntu to 16.04). Developers / authors using Docker would need to run docker-compose build again.

pjanik commented 7 years ago

@scytacki or @sfentress, could you take a look at it? Lab Interactives Site build got broken again due to NPM issues:

  1. https://travis-ci.org/concord-consortium/lab-interactives-site/builds/251076855
  2. https://github.com/concord-consortium/lab/issues/123#issuecomment-313401270

And this PR can fix it. I've rebased it, updated package.json (as it was causing some issues) and it works now: https://travis-ci.org/concord-consortium/lab-interactives-site/builds/251079062