search

concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

Greek translation for 5-amino-acids interactive #68

Closed pjanik closed 7 years ago

pjanik commented 7 years ago

Fixed version of this PR: https://github.com/concord-consortium/lab-interactives-site/pull/67

birbilis commented 7 years ago

actually "gr" isn't a correct ISO language code, "el" is (should use language codes, not country codes, e.g. en-US is a language code for english with a specifier about a certain kind of english). No meaning in using more specific codes for Greek like "el-GR", just "el" is ok. So need to fix this after fixing your system first if it expects "gr" instead of "el"

birbilis commented 7 years ago

...see more comments on this matter at the end of https://github.com/concord-consortium/lab/issues/123 discussion