search

concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

translating nn and nb #91

Open ghveem opened 4 years ago

ghveem commented 4 years ago

several new nn and nb

ghveem commented 4 years ago

Should "credits": include name of translator like "credits": "Thomas Bedin", ?

pjanik commented 4 years ago

Thank you. Translated models need i18nMetadata file, so students can see a menu with available languages. I've added this file to previously translated model in this commit: https://github.com/concord-consortium/lab-interactives-site/commit/10a0b8479b38b7e28a780c7cfc81ee7a191c62f7 Could you follow this pattern and add the necessary metadata files? There's a readme section describing it: https://github.com/concord-consortium/lab-interactives-site/blob/master/developer-doc/localization.md If something is unclear, let me know. Do you have a local copy of lab-interactives-site working?

Should "credits": include name of translator like "credits": "Thomas Bedin",

I don't think so. "credits" specifies the content of the credits dialog. You can see it when you click on Concord Consortium logo in the lower-left corner.

ghveem commented 4 years ago

Updated i18nmetadata in fresh files (translations) and updated the metadata-files with information about the translated files. I have not tried a local running copy.

pjanik commented 4 years ago

Thanks. I think the English versions are missing "i18nMetadata" value. It's necessary to be able to see the flag button and be able to switch to another language. Did you try to run a local copy? Basic instructions can work and there's also solution based on docker (one more tool, but more bulletproof). With this amount of changes, it'd be useful to see if things work correctly and iterate here faster (we're not actively working on this project at the moment).

ddamelin commented 9 months ago

@ghveem there are still some issues with this pull request. Have you run this locally? If so you will see that most (all?) of the translated interactives don't have the flag to allow the user to switch languages. To fix that you'll need to edit the english version of the interactive so that the "i18nMetadata" property points to the metadata file that describes where to find the other languages. You've added this information to your own translated interactive files, but not to the english version of the file. See https://github.com/concord-consortium/lab-interactives-site/blob/master/src/interactives/samples/1-oil-and-water-shake.json for a working example.

Also the text on line 5 of src/locales/nb/interactives/sam/intermolecular-attractions/3-2-boiling-point-and-solubility.json should be on line 4 to close the quotes.

Same for line 76 of src/locales/nb/interactives/sam/intermolecular-attractions/4-strengthening-dipole-dipole-attractions.json

And line 76 of src/locales/nn/interactives/sam/intermolecular-attractions/4-strengthening-dipole-dipole-attractions.json

ghveem commented 9 months ago

I'm sorry. This is not ready or ment to be a PR. I just tried to sync our version from your master.