search

concord-consortium / lab-interactives-site

Set of interactives built using the Lab Framework from the Concord Consortium
lab.concord.org
Other
14 stars 28 forks source link

Remove FingerprintJS #96

Closed pjanik closed 4 years ago

pjanik commented 4 years ago

FingerprintJS was used to generate browser id value in the benchmark results spreadsheet: https://docs.google.com/spreadsheets/d/1M52wtJSljm2iNia-De1PoDsyjGOmifyWuBb0iTkc7mc/edit?usp=drive_web&ouid=118385207742307288199 However, it was disabled in the production version anyway due to privacy concerns.

I had to remove it, as it was breaking builds on TravisCI recently. I guess the repo has been reorganized and the version we're using was completely removed. All newer ones I could find were async, so I didn't think it'd make sense to spend time to adjust the code.

Benchmarks still work, and I don't really think we need browser_id at this point.

This section has been removed from interactives.html page:

Screenshot 2020-09-17 at 12 02 25

Demo/test: https://lab.concord.org/branch/no-fingerprint/interactives.html#interactives/samples/1-oil-and-water-shake.json

scytacki commented 4 years ago

@pjanik I'll let you merge this since it will trigger a deploy.