concord-consortium / lab

HTML5-based scientific models, visualizations, graphing, and probeware
http://lab-framework.concord.org/
MIT License
57 stars 38 forks source link

Allow Data Hierarchy reorg when embedded in CODAP #133

Closed dstrawberrygirl closed 6 years ago

dstrawberrygirl commented 6 years ago

Having reviewed the PT story and checked the corresponding documentation I've added the attribute to the call to the update action. I am unsure how to test whether this works as required without additional information on the CODAP use case, but I was able to compile and embed in a local CODAP instance and export data for analysis.

jsandoe commented 6 years ago

To test allowing reorganization in CODAP you would open a lab interactive that works with CODAP (e.g. the parachute model) in CODAP, run it and submit the data to CODAP. You should then see a case table open in CODAP. You should be able to grab the header of any column of the case table and drag it to the left. When you start the drag you should some yellowish highlighting around regions of the case table indicating drop targets. If you drag an attribute all the way to the whitespace on the left side of the component, it should highlight an show a message like "drop attribute to create a new collection"

dstrawberrygirl commented 6 years ago

thanks @jsandoe - it's possible to test with the build of Lab from this branch at http://lab-framework.concord.org/branch/codap-allow-data-reorg/ - I believe it's working as you described, since I was able to group by dragging column headers over to the left, but let me know if there are any problems.

jsandoe commented 6 years ago

@dstrawberrygirl, looks good to me, too.