search

concord-consortium / lab

HTML5-based scientific models, visualizations, graphing, and probeware
http://lab-framework.concord.org/
MIT License
57 stars 38 forks source link

Update translations.json #156

Closed bgareth closed 4 years ago

bgareth commented 4 years ago

In addition to the Learning Sandbox translation contribution pull request in the 'lab-interactives-site" rep, we have included some UI translations in the respective languages.

dstrawberrygirl commented 4 years ago

The updates to the interactives include some Simplified Chinese translations, but we do not yet have an icon to represent Simplified Chinese. We need an icon, the same size and shape as a flag, that can be displayed when the language code is shown as zh. The icon should be fairly simple - a white rectangle with the character 简 to represent Simplified Chinese, ideally with the same dimensions and drop shadow as the other icons. If you aren't sure how to do this, let me know and I can take a look. Thanks!

bgareth commented 4 years ago

Good day.

The Simplified Chinese (zh.png) flag has been added to our branch/rep. Please review and let us know if there are any queries or updates. The 'ko' and 'ja' language codes have also been amended to match the flag names in the respective repo.

Kind regards.

On Mon, Sep 28, 2020 at 5:16 PM Chris Hart notifications@github.com wrote:

The updates to the interactives include some Simplified Chinese translations, but we do not yet have an icon to represent Simplified Chinese. We need an icon, the same size and shape as a flag, that can be displayed when the language code is shown as zh. The icon should be fairly simple - a white rectangle with the character 简 to represent Simplified Chinese, ideally with the same dimensions and drop shadow as the other icons. If you aren't sure how to do this, let me know and I can take a look. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/concord-consortium/lab/pull/156#issuecomment-700073071, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARBUNPPS2SRIC7HER3WUYI3SICSGBANCNFSM4RUWC2UQ .

dstrawberrygirl commented 4 years ago

Looks great, thanks!