Remove prototype from app/views/shared

concord-consortium / rigse

Concord Consortium Portal (somewhat like an LMS)

MIT License

9 stars 11 forks source link

Remove prototype from app/views/shared #598

Open emilywatkins opened 6 years ago

emilywatkins commented 6 years ago

Ref #457

app/views/shared/_accordion_nav.html.haml:34 #sortable_element
app/views/shared/_accordion_nav.html.haml:35 #sortable_element
app/views/shared/_activity_trail.html.haml:27 #link_to_function
app/views/shared/_general_accordion_nav.html.haml:62 #sortable_element
app/views/shared/_general_accordion_nav.html.haml:64 #sortable_element
app/views/shared/_offering_for_teacher.html.haml:26 #sortable_element
app/views/shared/_page_header.html.haml:4 #link_to_remote uses CALLBACKS and AJAX_OPTIONS
app/views/shared/_runnable.html.haml:12 #draggable_element
app/views/shared/_runnables_listing.html.haml:36 #draggable_element

scytacki commented 6 years ago

general_accordion_nav can be removed: It is used here: https://github.com/concord-consortium/rigse/blob/b7c6dba3e7c33c90265e12f6e54334155888da8a/app/views/layouts/application.html.haml#L82-L87 In those 3 cases it not necessary anymore. It is OK in those cases to fall through to the 'portal_teacher' and 'portal_student' cases.

scytacki commented 6 years ago

It looks like accordion_nav, and activity_trail are not used anywhere.

I'm pretty sure the sortable_element part of offering_for_teacher can be removed. I believe this partial is only rendered on an admin page here: /portal/classes/[id] It would be useful to make a list of top level pages where offering_for_teacher rendered.

scytacki commented 6 years ago

page_header is not used.

It also looks like _runnable.html.haml is also only used in one place that isn't available anymore: ClazzesController#remove_offering.

scytacki commented 6 years ago

I suspect runnables_listing can be removed or simplified. The UI that teachers use to reorder offerings in their classes has been moved to portal-pages. It would be helpful to trace through this one as well. For example it seems like it is used by ClazzesController#edit_offerings, which has a member route defined. However when I request the page on the staging server I get at 'page does not exist' response. The URL I tried was: https://learn.staging.concord.org/portal/classes/1/edit_offerings

scytacki commented 6 years ago

To summarize I believe all these partials and views can either be removed, or their dynamic (sortable draggable) elements can be removed. I'll mark it as dead for that reason.