search

concordancejs / concordance

Compare, format, diff and serialize any JavaScript value
ISC License
207 stars 15 forks source link

Drop the `moment` dependency #30

Closed sindresorhus closed 7 years ago

sindresorhus commented 7 years ago

It takes up 3.1 MB on disk.

I also switched from Z to UTC as it’s more user-friendly.

novemberborn commented 7 years ago

Cheers, will merge on the weekend.

I also switched from Z to UTC as it’s more user-friendly.

Do you reckon this is a breaking change? I'd argue it wouldn't be for AVA, but it might be for people using concordance directly.

sindresorhus commented 7 years ago

I don't see why it would be a breaking change. It's just the output. But you probably have better insight than me why it might me.

novemberborn commented 7 years ago

People might end up storing the output, doing string comparisons on it, etc. But it doesn't seem pragmatic to treat formatting changes as breaking.