search

concordancejs / concordance

Compare, format, diff and serialize any JavaScript value
ISC License
207 stars 15 forks source link

Add tests for pluginRegistry #57

Closed bunysae closed 4 years ago

bunysae commented 4 years ago

I added tests for pluginRegistry in order to fix #1.

novemberborn commented 4 years ago

Thanks for your PR @bunysae. I did not open my editor this weekend so I haven't had time yet to look into this, sorry.

novemberborn commented 4 years ago

So I don't remember much about how this code works, but I just did update the tooling and dependencies. Could you try rebasing? Apologies for any conflicts.

novemberborn commented 4 years ago

@bunysae I don't think that did the trick. All the changes are now showing up in the diff, and according to GitHub there's still merge conflicts.

bunysae commented 4 years ago

@novemberborn Fixed :). I rebased the wrong branch yesterday.

novemberborn commented 4 years ago

@bunysae cool, thanks. Looks like there are some linter errors now.

You can run npx as-i-preach --fix to fix.

novemberborn commented 4 years ago

Thank you @bunysae.