search

concordion / concordion-excel-extension

Allows Concordion specifications to be in Excel format rather than HTML
Other
9 stars 12 forks source link

Run sheet as an example #11

Closed GoGoris closed 5 years ago

GoGoris commented 7 years ago

Is it possible to table or sheet as an example? I tried to put it on a div but I don't know how to get this in excel. I tried putting concordion:excel on a cell above my table, but this didn't work. Empty cells are not written to my report and if I create a note on a cell that contains text, the concordion:example is put on the span tag instead of the div.

Why doesn't each sheet run as an example by default? If I look at the report, they already have the css class "example".

GoGoris commented 7 years ago

I just found out that I can add it to the div by using (div)concordion:example="Title"

robmoffat commented 7 years ago

So this is fixed then, yes?

GoGoris commented 7 years ago

Yes, the (div) is a nice workaround. The question is only whether this should become default behavior or not? Sorry for the late reply btw, I missed it because of my holidays ...

robmoffat commented 7 years ago

HI Steven,

Can you explain a bit further?

The (element) notation is to allow you to add the attribute to any given parent of the current element, so the default behaviour, when this is excluded is just to add to the current element.

It’s useful for tables and such mainly. What are you suggesting, exactly?

cheers, Rob

On 26 Oct 2017, at 10:02, Steven Goris notifications@github.com wrote:

Yes, the (div) is a nice workaround. The question is only whether this should become default behavior or not?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/concordion/concordion-excel-extension/issues/11#issuecomment-339600287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAitYQPPNxDz4Oyc0lQaeQopg0MRIYxgks5swEqRgaJpZM4OWwG4.

GoGoris commented 7 years ago

Hi Rob,

Using a sheet will generate the same report as using an example with the html or markup syntax. So I would expect every sheet to also runs as an example. Doesn't everyone want a seperate test with the name of the sheet in Junit when they run a specification? You know directly where the specification is failing from looking at the terminal output. I fear that many will find it annoying that there tests don't show as expected in junit and won't know that this is caused by not running them as an example.

Regards, Steven

robmoffat commented 6 years ago

Hi Steven,

Sorry for the late reply.. Just not been sure what to write.

I expect you’re right - I’m not close enough to have an opinion on all this right now, I haven’t used concordion in a while.

I take it there would be no call in having more than one example in the same sheet then?

Do you want to submit a PR or get committer access to this?

cheers,

Rob

On 31 Oct 2017, at 18:14, Steven Goris notifications@github.com wrote:

Hi Rob,

Using a sheet will generate the same report as using an example with the html or markup syntax. So I would expect every sheet to also runs as an example. Doesn't everyone want a seperate test with the name of the sheet in Junit when they run a specification? You know directly where the specification is failing from looking at the terminal output. I fear that many will find it annoying that there tests don't show as expected in junit and won't know that this is caused by not running them as an example.

Regards, Steven

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/concordion/concordion-excel-extension/issues/11#issuecomment-340854261, or mute the thread https://github.com/notifications/unsubscribe-auth/AAitYTykbfYdiUuMOH0cX-pw9waQhqkdks5sx2OPgaJpZM4OWwG4.

GoGoris commented 6 years ago

Hi Rob,

No problem, I also didn't use Concordion for some months now because I am on a new project. I know that my old colleagues are still using it for their tests but they are using the workaround. Because there are no other participants that are bothered by this, I suggest that we just leave it for now. If we start working with Concordion again in the future we can still pick this up.

Anyway thanks again for sharing this project in the first place. It was a great solution and it really helped us organize our test cases at my previous project! I think it doesn't get the appreciation it deserves.

Cheers, Steven

robmoffat commented 5 years ago

Closing due to inactivity