search

concordion / concordion-excel-extension

Allows Concordion specifications to be in Excel format rather than HTML
Other
9 stars 12 forks source link

apache POI library upgraded #17

Closed wilczelyko closed 5 years ago

wilczelyko commented 5 years ago

Upgrade of Apache POI library as old version contained serious known vulnerabilities.

robmoffat commented 5 years ago

I checked out your code - I see the problem you're referring to.

My feeling is that this is something we need to fix in the test. I.e setting the Locale of Java at the start of the test to ensure we get a consistent response.

I am running in en_GB locale, and it might be best to just fix this at the start of the test:

AbstractSpecTest:

static {
        Locale.setDefault(Locale.UK);
        ExcelExtension.setConversionMap(conversions);
    }

However, even I still have a problem where true has now turned to TRUE and I think this might be due to using a later JDK.

Possibly best if we just update the expectation for that?

What do you think?

Addendum:

adding toLowerCase to expectedString and actualString also works for me, and is probably fair enough.

wilczelyko commented 5 years ago

Agreed. Fixed as you advised and also replaced currency symbols with codes (only in input) - it also gave me problems (same behaviour as with previous version of apache POI).

robmoffat commented 5 years ago

I've merged your changes- I think v2.1.2 of c.e.e. should sync with maven central within the day.

wilczelyko commented 5 years ago

Thx