search

concordion / concordion-excel-extension

Allows Concordion specifications to be in Excel format rather than HTML
Other
9 stars 12 forks source link

various issues in error handling #19

Closed vgheo closed 4 years ago

vgheo commented 4 years ago

1. https://github.com/concordion/concordion-excel-extension/blob/f55b4df2097ab56413402c5fbd4a32f8306ea33d/src/main/java/org/concordion/ext/excel/conversion/cell/BasicCellConversionStrategy.java#L42

  1. https://github.com/concordion/concordion-excel-extension/blob/f55b4df2097ab56413402c5fbd4a32f8306ea33d/src/main/java/org/concordion/ext/excel/ExcelCellConversionException.java#L6

NPE on all cases when arguments are null

  1. https://github.com/concordion/concordion-excel-extension/blob/f55b4df2097ab56413402c5fbd4a32f8306ea33d/src/main/java/org/concordion/ext/excel/conversion/row/BasicTableStrategy.java#L60

fail to wrap caught exception - suppresses diagnosis information

  1. Diagnosis issue - ExcelCellConversionException - should also print sheet information in location.
    • helpful on excels with multiple sheets