search

concordion / concordion-excel-extension

Allows Concordion specifications to be in Excel format rather than HTML
Other
9 stars 12 forks source link

Update on poi libs version #25

Closed tiagotcsilva closed 10 months ago

tiagotcsilva commented 10 months ago

The poi libs version were very outdated causing conflict problems with other project dependencies.

nigelcharman commented 10 months ago

@robmoffat are you happy for us to pull and release these changes?

robmoffat commented 10 months ago

Hi @nigelcharman,

Seeing some failures on the GitHub actions - is it worth trying to fix these first?

tiagotcsilva commented 10 months ago

Just to add some information, i used jdk17 and everything worked nicely

robmoffat commented 10 months ago

Hi @tiagotcsilva, do you want to have a go at fixing the actions? Feel free to move to a newer JDK - I expect concordion has a minimum JDK number they’re supporting, though.

I’ll run the actions for you if you comment again on this PR. I’m away from my desk but I’ll see the email. Cheers

tiagotcsilva commented 10 months ago

Hi @robmoffat i just upgraded gradle version to 8.5, removed jdk 1.8 compilation and added jdk17.

I executed the actions on my fork and it seems ok.

nigelcharman commented 10 months ago

@tiagotcsilva thanks for making these changes. It looks like we'll need to make a few changes to the publishing mechanism to release it. Are you OK to wait until after the new year for an official release?

tiagotcsilva commented 10 months ago

@nigelcharman it's ok, no problem.