search

concordion / cubano

A packaged framework for implementing web and API test suites. Builds on Concordion to bring your software delivery team together around living documentation.
http://concordion.org/cubano/framework
Apache License 2.0
15 stars 2 forks source link

Modified configuration loading mechanism #26

Closed nigelcharman closed 7 years ago

nigelcharman commented 7 years ago

Renamed ConfigLoader to PropertiesLoader. Introduced PropertyLoader and DefaultPropertyLoader Introduced ProxyConfig which contains just the proxy config settings Renamed package to org.concordion.cubano.config Made Config and WebDriverConfig final Removed inheritance from Config and WebDriverConfig Introduced singletons for DefaultPropertiesLoader, Config and WebDriverConfig to ensure that properties files are only read once, and make it easy to access Config and WebDriverConfig Removed HttpEasyConfig, since this just uses ProxyConfig Modified WebDriverConfig to mirror Config and delegate to PropertyLoader

Any specific AppConfig will no longer be able to inherit from Config or WebDriverConfig and will need to be modified to delegate to PropertyLoader. See WebDriverConfig for example code.

nigelcharman commented 7 years ago

Please review and merge PR #25 first - this PR is based off that one and the number of changes will reduce once it is merged.

nigelcharman commented 7 years ago

Also, I'll look to update cubano-template to show how the AppConfig needs to change.