search

concordusapps / grunt-haml

Process HAML templates to precompiled JavaScript or rendered HTML.
https://npmjs.org/package/grunt-haml
MIT License
41 stars 28 forks source link

Update to grunt 0.4, and node 0.10 GH-6 #8

Closed joneshf closed 11 years ago

joneshf commented 11 years ago

So I don't have push access to the original repo. But this should be for issue 6: https://github.com/concordusapps/grunt-haml/issues/6

I had a concern though, we were using helpers.options in the task. Is that necessary for something? It seems that this.options provides the task with the options defined in Gruntfile.js. Or is there something else that is going on? I removed the dependency for grunt-lib-contrib if we don't need that helper anymore. If so, I can add that back in. I also tried to clean up the transpile function a bit, so that it is easier to read and maintain. Hopefully that should make adding additional languages easier.

Updated to node 0.10.x. The tests pass on my machine with npm test, dunno about travis yet though. I lied, travis is all good.

mehcode commented 11 years ago

I had a concern though, we were using helpers.options in the task. Is that necessary for something? It seems that this.options provides the task with the options defined in Gruntfile.js. Or is there something else that is going on? I removed the dependency for grunt-lib-contrib if we don't need that helper anymore.

It looks like helpers.options and this.options are the same thing. It seems grunt moved it from the contrib lib to core when 0.4 was released (helpers.options isn't in grunt-lib-contrib anymore as well).

Great stuff! Thanks for the work.