concordusapps / grunt-haml

Process HAML templates to precompiled JavaScript or rendered HTML.
https://npmjs.org/package/grunt-haml
MIT License
41 stars 28 forks source link

Added support for Ruby haml #9

Closed DavidMikeSimon closed 11 years ago

DavidMikeSimon commented 11 years ago

Sometimes I like to use the original haml implementation in Ruby to compile templates. It has a somewhat more forgiving parser than haml-js, particularly when it comes to dealing with long attribute lists, something that Angular is notorious for.

This pullreq adds support for shelling out to the haml command installed by the haml gem, if the language setting is set to ruby. I've also created some tests for this feature, doing a little refactoring of the existing test code in the process, and documented the new feature.

joneshf commented 11 years ago

Cool stuff. Unfortunately, travis doesn't have haml installed, so the build fails. It runs locally, but I have haml installed. Can you see about packaging this up for travis, something like bundler, rvm or similar? Thanks

DavidMikeSimon commented 11 years ago

Okay, I think that's everything. :-) Anything else you'd like changed?

joneshf commented 11 years ago

Wicked! I'll merge it right away. Thanks!

mehcode commented 11 years ago

@DavidMikeSimon I've added you as contributor, so you can directly push to master if you want to contribute more time and features to grunt-haml. Thanks a lot!