concordusapps / inquire.js

Generate advanced query strings.
http://concordusapps.github.io/inquire.js/
MIT License
11 stars 2 forks source link

UMD loader is bunk #12

Closed joneshf closed 10 years ago

joneshf commented 11 years ago

The loader checks if exports is an object or someting, then just assumes that module exists. This is an issue when some one else has already defined exports but not module. Good old js.

joneshf commented 10 years ago

After speaking with a few folks, this shouldn't really be a concern for this library. We can never really stop someone from creating random variables module or exports so there's not much we can do except hope and pray.