search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 176 forks source link

What kind of list? #145

Closed steadysupply closed 4 years ago

steadysupply commented 4 years ago

https://github.com/concourse/concourse-chart/blob/5d9c6e46e5bf81e67a02a8e7ac1e4b63dadcd485/values.yaml#L2261-L2263

mentions a list

https://github.com/concourse/concourse-chart/blob/5d9c6e46e5bf81e67a02a8e7ac1e4b63dadcd485/templates/web-secrets.yaml#L37

but the value is just encoded and sent along.

I assume the "list" is comma-separated or some such?

chenbh commented 4 years ago

@steadysupply yeah, it's comma separated user1:pass1,user2:pass2.

Please see https://concourse-ci.org/local-auth.html, the secret gets used by: https://github.com/concourse/concourse-chart/blob/5d9c6e46e5bf81e67a02a8e7ac1e4b63dadcd485/templates/web-deployment.yaml#L223-L227

taylorsilva commented 4 years ago

We could add an example here to make it clear what format is expected. The key directly above localUsers has an example: https://github.com/concourse/concourse-chart/blob/5d9c6e46e5bf81e67a02a8e7ac1e4b63dadcd485/values.yaml#L2248-L2259

steadysupply commented 4 years ago

Made a PR to push this through.