drthornt commented 3 years ago

Existing Issue

Fixes #160 160

Why do we need this PR?

Changes proposed in this pull request

Change default value of web.clusterip

Contributor Checklist

[X ] Variables are documented in the README.md
[dev] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

xtremerui commented 3 years ago

@drthornt could you fix the DCO error?

xtremerui commented 3 years ago

@drthornt hi just bumping to check if you got time to sign your commit so we could merge it? This is a fix that good to have and we'd like to have it merged now.

If not, could we close this PR so we could fix it? Thx.

concourse / concourse-chart

fixes 160 clusterip values #163

Existing Issue

Why do we need this PR?

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist