concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

145 stars 177 forks source link

rbac.authorization.k8s.io/v1beta1 -> /v1 #164

Closed clarafu closed 3 years ago

clarafu commented 3 years ago

Existing Issue

Fix linter failures from the lint-and-install-test in the helm pr pipelines https://ci.concourse-ci.org/teams/main/pipelines/helm-prs/jobs/lint-and-install-test/builds/138. It is fixed in the dev branch but master branch also needs the fix too for prs to get merged into the branch.

Changes proposed in this pull request

rbac.authorization.k8s.io/v1beta1 -> /v1

It looks like most of v1beta1 was deprecated in v1.17 and will be removed by v1.22 https://godoc.org/k8s.io/api/rbac/v1beta1#ClusterRole

Contributor Checklist

[ ] Variables are documented in the README.md
[ ] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

taylorsilva commented 3 years ago

I'm going to release a patch of the chart with this change now.