concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 177 forks source link

Add ability to define annotations for web/worker Service accounts #171

Closed Caprowni closed 3 years ago

Caprowni commented 3 years ago

Existing Issue

Fixes #173

Changes proposed in this pull request

Contributor Checklist

Merging to master should be okay (?) happy to move to dev if need be, as I mentioned i've already worked around this by creating my own service accounts but would be nice to have this natively supported.

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
Caprowni commented 3 years ago

@YoussB Hey! Thanks for reviewing my PR, I fixed the indentation you mentioned, i'm not sure about the values.yaml comment though as i've already added the definitions into the values.yaml at the root of the repo.

Is there something i've missed?