concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

145 stars 177 forks source link

Allow secrets annotations #172

Closed sdurrheimer closed 3 years ago

sdurrheimer commented 3 years ago

Existing Issue

Fixes #170

Changes proposed in this pull request

Add annotations capabilities for the web and worker secrets.

Contributor Checklist

[x] Variables are documented in the README.md
[x] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

sdurrheimer commented 3 years ago

Thanks @sdurrheimer, The PR looks good as it is. I am just wondering, does it make sense to add more control over which annotations go to the web-secrets and which should go to the worker-secrets?

Right now I don't see the need for it so I would say keep it simple. But I can split it into two fields if you prefer so.