concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

145 stars 177 forks source link

Resolve clusterIP issues from Helm3's 3-way match #188

Closed JohnLBevan closed 3 years ago

JohnLBevan commented 3 years ago

Existing Issue

Fixes #187.

Contributor Checklist

[✓ ] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

Jasstkn commented 3 years ago

@JohnLBevan hi! Why did you close this PR?

JohnLBevan commented 3 years ago

@Jasstkn sorry for the slow response; only just discovered the GitHub inbox!

@JohnLBevan hi! Why did you close this PR?

My proposed fix wasn't appropriate (see review comments from @aoldershaw on 8th Dec).