concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 177 forks source link

Defaulting vault backend to `token` #199

Closed tinygrasshopper closed 3 years ago

tinygrasshopper commented 3 years ago

Why do we need this PR?

Vault authentication backend, leave this blank if using an initial periodic token

The current comment on the property is inaccurate, as the initial periodic token is not templated in and the webworker fails to start if the authBackend is not set

Changes proposed in this pull request

Changes the default on the chart to be "token", which would enable the chart to work for initial periodic tokens be default, which is what the documented intent seems to be.

taylorsilva commented 3 years ago

Gone stale :(