concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
145 stars 177 forks source link

web.service.api.NodePort not honored #212

Closed DonBower closed 3 years ago

DonBower commented 3 years ago

In the charts/templates/web-api-svc.yaml file, line 39 checks for the existence of a value at .Values.web.service.api.atcNodePort, and then sets the nodePort: value on line 40 to .Values.web.service.api.NodePort. It should check for the existence of .Values.web.service.api.NodePort, not .atcNodePort

Documentation for NodePort says: Sets the nodePort for api when using NodePort

It Does not mention atcNodePort.

DonBower commented 3 years ago

This workaround produces a NodePort service at 30001, which is what is desired for my case:

web:
  replicas: 3
  service:
    api:
      type: NodePort
      atcNodePort: 30008
      NodePort: 30001