concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

143 stars 176 forks source link

Remove duplicate key in values.yml #218

Closed ionphractal closed 3 years ago

ionphractal commented 3 years ago

Existing Issue

no

Why do we need this PR?

The values.yml contains a duplicate key which can irritate parsers as well as human readers.

Changes proposed in this pull request

Remove the duplicate key in values.yml

Contributor Checklist

[x] Variables are documented in the README.md
- unchanged: no additional variable, none removed
[x] Which branch are you merging into?
- master

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)

ionphractal commented 3 years ago

yup, human error, we totally added this flag twice. It's also duplicated in the template/web-deployment.yaml on lines 1258-1261. Could you remove those too?

What parser did you use to find this?

First commit: 9141dcd Second commit: d256063

Also removed the lines in web-deployment.yml. My actual issue was having concourse manually deployed with a custom values.yml through helm and then trying to manage it with kubeapps threw an error in kubeapps about the duplicate key when trying to upgrade the deployment. Another error came up when I tried to compare different versions. For that I wanted to sort the yaml file. It worked with "bosh int" but it threw an error on vscode YAML Sort plugin.