Closed ari-becker closed 3 years ago
Hi @taylorsilva , sorry for the delay, I was on vacation for a bit.
I switched gears here slightly and proposed a web.ingress.rulesOverride
option instead, which allows the user to have more control. It's cleaner (in terms of the chart) and probably more flexible too.
What do you think?
(side note: I see the CI build failure, but when I clicked the link, it's stuck on loading...
, so I'm not sure what to do here).
Why do we need this PR?
Allows for adding additional, earlier paths to web-ingress. The impetus for this change is to allow for setting up an HTTP -> HTTPS redirect with AWS ALBs. For example:
Reference: https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/tasks/ssl_redirect/
Contributor Checklist
README.md
master
is for changes related to the current release of theconcourse/concourse:latest
image and should be good to publish immediatelydev
is for changes related to the next release of Concourse (aka unpublished code onmaster
in concourse/concourse)Reviewer Checklist