search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 176 forks source link

postgresql sslmode "require" should not require cert/key #221

Open jmccann opened 3 years ago

jmccann commented 3 years ago

It seems only for sslmode disable that the chart will skip including postgres cert/keys.

But I think mode require also does not require a cert/key to operate. (at least, it's been working for me outside of using this chart)

sslmode require does not do host validation (😢 ) but it does allow you to have encryption over the wire still.

I plan to PR an update to the chart to include sslmode require to not include cert/key in addition to mode disable.

jmccann commented 3 years ago

Looks like a workaround is to publish some fake secrets at https://github.com/concourse/concourse-chart/blob/7c2e39da64d822109f64391d741b59d69924ecd0/templates/web-deployment.yaml#L1540-L1550

Then the chart works with with volumes/mount/files described but since they are not set/referenced via env they aren't used.