concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

143 stars 176 forks source link

allow deploy prometheus with different service type #227

Closed xtremerui closed 3 years ago

xtremerui commented 3 years ago

Fixes #213 .

Changes proposed in this pull request

Change prometheus service template to allow deployed as NodePort, ClusterIP or LoadBalancer service.

remove "None" value for cluster IP in values.yml. refer to #163.

Contributor Checklist

[ ] Variables are documented in the README.md
[ ] Which branch are you merging into?
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)