concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

143 stars 176 forks source link

Breaking: Bump postgres chart version to 10.3.13 #232

Closed taylorsilva closed 3 years ago

taylorsilva commented 3 years ago

Why do we need this PR?

Breaking changes: https://github.com/bitnami/charts/tree/master/bitnami/postgresql#to-1000

tldr: uses helm api v2, same as our chart. Some name changes like master -> primary, slave -> readReplicas

We should make this a major bump of the chart and link to the bitnami readme above

Contributor Checklist

[ ] Variables are documented in the README.md
[x] Which branch are you merging into? master
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[x] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[x] Is the correct branch targeted? (master or dev)

xtremerui commented 3 years ago

LGTM. I have added it to milestone 16.0.0 for next major release.