concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

143 stars 176 forks source link

Don't set cluster ip if no value is specified #237

Closed taylorsilva closed 3 years ago

taylorsilva commented 3 years ago

fixes #187

I verified that when no value is set that clusterIP does not render. When a value is set it does render.

Contributor Checklist

[ ] Variables are documented in the README.md
[ ] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

[ ] Code reviewed

[ ] Topgun tests run

[ ] Back-port if needed

[ ] Is the correct branch targeted? (master or dev)