search

concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
143 stars 176 forks source link

allow configuring priorityClassName for pods #253

Closed chrisfarms closed 3 years ago

chrisfarms commented 3 years ago

Changes proposed in this pull request

this add new (optional) web.priorityClassName and worker.priorityClassName values for configuring the PodPriority of the web/worker pods.

See: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#pod-priority

Why do we need this PR?

when attempting to run concourse workers that consume a large percentage of a node's resources you can come up against scheduling issues due to poor bin-packing of pods on to nodes.

setting pod priorities can be useful in this case, allowing the scheduler shuffle things around and evict pods to make room.

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
taylorsilva commented 3 years ago

Thanks for the PR! I'll take a look this week.