concourse / concourse-chart

Helm chart to install Concourse

Apache License 2.0

146 stars 176 forks source link

Closed taylorsilva closed 3 years ago

taylorsilva commented 3 years ago

added in concourse/concourse#7487

Contributor Checklist

[x] Variables are documented in the README.md
[x] Which branch are you merging into?
- master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
- dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

taylorsilva commented 3 years ago

@muntac that only applies to the k8s specific stuff. None of the Concourse flags/env vars are in the README.

That actually made me notice that the containerd stuff looks like it may be in the wrong section...

taylorsilva commented 3 years ago

ah okay it's not!

So all the flags/env vars fall under the concourse.<worker/web> key. All the k8s specific stuff is under the top-level web or worker keys.

Looks like the README has the containerd stuff listed under worker.containerd. when it should be concourse.worker.containerd. Oops!