concourse / concourse-chart

Helm chart to install Concourse
Apache License 2.0
146 stars 176 forks source link

Add HPA autoscaling behavior field #282

Closed taylorshaulis closed 3 years ago

taylorshaulis commented 3 years ago

Why do we need this PR?

This PR adds the behavior field to the worker HPA template. Once added the behavior field will allow users to adjust scale down and scale up windows beyond the default kubernetes settings.

https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#default-behavior

Changes proposed in this pull request

Contributor Checklist

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not fill out this section.

  • [ ] Code reviewed
  • [ ] Topgun tests run
  • [ ] Back-port if needed
  • [ ] Is the correct branch targeted? (master or dev)
taylorshaulis commented 3 years ago

The sub settings for worker.autoscaling are not documented in the README.md. If that is necessary I can add documentation for the behavior field.

This is something new so hopefully we can just merge into the master branch without needing to back-port or wait for the next concourse release.